Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granular CRN for snapshot data sources and resources #158

Closed
wants to merge 12 commits into from

Conversation

Alexander-Kita
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

pi_snapshot (r):

=== RUN   TestAccIBMPIInstanceSnapshotbasic
--- PASS: TestAccIBMPIInstanceSnapshotbasic (913.55s)
PASS

pi_snapshot (d)

=== RUN   TestAccIBMPIInstanceSnapshotDataSource_basic
--- PASS: TestAccIBMPIInstanceSnapshotDataSource_basic (9.02s)
PASS

pi_snapshots (d)

=== RUN   TestAccIBMPIInstanceSnapshotsDataSource_basic
--- PASS: TestAccIBMPIInstanceSnapshotsDataSource_basic (8.38s)
PASS

pi_pvm_snapshots (d)

=== RUN   TestAccIBMPISnapshotDataSource_basic
--- PASS: TestAccIBMPISnapshotDataSource_basic (12.73s)
PASS

Description:

  • Adds granular CRN attributes and arguments to snapshot resources
  • Updated tests with CRN
  • Minor refactoring

@Alexander-Kita
Copy link
Collaborator Author

Re-requesting Review due to adding CRN checks.

@michaelkad michaelkad added the Q3 label Sep 13, 2024
@Alexander-Kita
Copy link
Collaborator Author

Opened in main repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants